Turns out reading from the HID interrupt channel the right way is a bit more challenging than I expected. Unfortunately there's no Bluetooth equivalent of the continuous reader for USB pipes in WDF so you've to implement that thing yourself. There are reference implementations available but they're so "ripped apart" and all over the place I'll instead try to write it from scratch to better understand what's happening. Maybe I get somewhere today, we'll see
Bluetooth Filter Driver for DS3-compatibility - research notes
There we go
2019/02/10-17:52:51.880 TRACE_LEVEL_VERBOSE BthPS3_PDO_EvtWdfIoQueueIoInternalDeviceControl Entry 2019/02/10-17:52:51.880 TRACE_LEVEL_VERBOSE BthPS3_EvtWdfIoQueueIoInternalDeviceControl Entry 2019/02/10-17:52:51.880 TRACE_LEVEL_VERBOSE bufferLength: 50 2019/02/10-17:52:51.885 TRACE_LEVEL_VERBOSE brb->BufferSize: 50, brb->RemainingBufferSize: 0 2019/02/10-17:52:51.885 TRACE_LEVEL_INFORMATION A1 01 00 00 00 00 00 7A 81 80 7D 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 03 05 16 FF CD 00 01 33 00 77 00 40 01 FA 01 ED 01 91 00 05 2019/02/10-17:52:51.885 TRACE_LEVEL_VERBOSE BthPS3_PDO_EvtWdfIoQueueIoInternalDeviceControl Exit
What threw me off for quite a few hours was the weird behavior of the
RemainingBufferSize member of the _BRB_L2CA_ACL_TRANSFER structure, which was increasing fast to values way higher than the buffer I supplied could hold. Turns out this field is not talking about the
Buffer member the caller supplies but the internal buffer of the Bluetooth host which tells you how many bytes have already come in from the remote device and are available to be read by further calls with that same BRB. I don't think the reference code I had a peek at did take that into account as this value was subtracted from
BufferSize which could lead to a negative value resulting in
Now that that's sorted out off to cleaning up this mess and looking for leaking memory
Going the extra mile today: testing the PS Move Navigation controller Connection established:
2019/02/10-18:32:19.445 TRACE_LEVEL_VERBOSE BthPS3IndicationCallback Entry 2019/02/10-18:32:19.445 TRACE_LEVEL_INFORMATION New connection for PSM 0x5053 from 70401E341 arrived 2019/02/10-18:32:19.445 TRACE_LEVEL_VERBOSE L2CAP_PS3_HandleRemoteConnect Entry 2019/02/10-18:32:19.446 TRACE_LEVEL_ERROR BTHPS3_GET_DEVICE_NAME failed with status STATUS_INVALID_PARAMETER (0xC000000D), dropping connection 2019/02/10-18:32:19.446 TRACE_LEVEL_VERBOSE L2CAP_PS3_DenyRemoteConnect Entry 2019/02/10-18:32:19.446 TRACE_LEVEL_VERBOSE L2CAP_PS3_DenyRemoteConnectCompleted Entry (STATUS_SUCCESS (0x00000000)) 2019/02/10-18:32:19.446 TRACE_LEVEL_VERBOSE L2CAP_PS3_DenyRemoteConnectCompleted Exit 2019/02/10-18:32:19.446 TRACE_LEVEL_VERBOSE L2CAP_PS3_DenyRemoteConnect Exit 2019/02/10-18:32:19.446 TRACE_LEVEL_VERBOSE BthPS3IndicationCallback Exit 2019/02/10-18:32:20.247 TRACE_LEVEL_VERBOSE BthPS3IndicationCallback Entry 2019/02/10-18:32:20.247 TRACE_LEVEL_INFORMATION New connection for PSM 0x5053 from 70401E341 arrived 2019/02/10-18:32:20.247 TRACE_LEVEL_VERBOSE L2CAP_PS3_HandleRemoteConnect Entry 2019/02/10-18:32:20.247 TRACE_LEVEL_INFORMATION ++ Device 70401E341 name: Navigation Controller 2019/02/10-18:32:20.247 TRACE_LEVEL_VERBOSE L2CAP_PS3_HandleRemoteConnect Exit (STATUS_SUCCESS (0x00000000)) 2019/02/10-18:32:20.247 TRACE_LEVEL_VERBOSE BthPS3IndicationCallback Exit 2019/02/10-18:32:20.247 TRACE_LEVEL_VERBOSE L2CAP_PS3_ConnectionIndicationCallback Entry (Indication: 0x0, Context: 0xFFFFFA80074DE0C0) 2019/02/10-18:32:20.247 TRACE_LEVEL_VERBOSE L2CAP_PS3_ConnectionIndicationCallback Exit 2019/02/10-18:32:20.497 TRACE_LEVEL_VERBOSE L2CAP_PS3_ControlConnectResponseCompleted Entry 2019/02/10-18:32:20.497 TRACE_LEVEL_INFORMATION Connection completion, status: STATUS_SUCCESS (0x00000000) 2019/02/10-18:32:20.497 TRACE_LEVEL_INFORMATION HID Control Channel connection established 2019/02/10-18:32:20.497 TRACE_LEVEL_VERBOSE L2CAP_PS3_ControlConnectResponseCompleted Exit 2019/02/10-18:32:20.689 TRACE_LEVEL_VERBOSE BthPS3IndicationCallback Entry 2019/02/10-18:32:20.689 TRACE_LEVEL_INFORMATION New connection for PSM 0x5055 from 70401E341 arrived 2019/02/10-18:32:20.689 TRACE_LEVEL_VERBOSE L2CAP_PS3_HandleRemoteConnect Entry 2019/02/10-18:32:20.689 TRACE_LEVEL_INFORMATION ++ Device 70401E341 name: Navigation Controller 2019/02/10-18:32:20.689 TRACE_LEVEL_VERBOSE ++ Found desired connection item in connection list 2019/02/10-18:32:20.689 TRACE_LEVEL_VERBOSE L2CAP_PS3_HandleRemoteConnect Exit (STATUS_SUCCESS (0x00000000)) 2019/02/10-18:32:20.689 TRACE_LEVEL_VERBOSE BthPS3IndicationCallback Exit 2019/02/10-18:32:20.689 TRACE_LEVEL_VERBOSE L2CAP_PS3_ConnectionIndicationCallback Entry (Indication: 0x0, Context: 0xFFFFFA80074DE0C0) 2019/02/10-18:32:20.689 TRACE_LEVEL_VERBOSE L2CAP_PS3_ConnectionIndicationCallback Exit 2019/02/10-18:32:20.783 TRACE_LEVEL_VERBOSE L2CAP_PS3_ConnectionIndicationCallback Entry (Indication: 0x4, Context: 0xFFFFFA80074DE0C0) 2019/02/10-18:32:20.783 TRACE_LEVEL_INFORMATION L2CAP_PS3_ConnectionIndicationCallback ++ IndicationRemoteConfigRequest 2019/02/10-18:32:20.783 TRACE_LEVEL_VERBOSE L2CAP_PS3_ConnectionIndicationCallback Exit 2019/02/10-18:32:20.824 TRACE_LEVEL_VERBOSE L2CAP_PS3_InterruptConnectResponseCompleted Entry 2019/02/10-18:32:20.824 TRACE_LEVEL_INFORMATION Connection completion, status: STATUS_SUCCESS (0x00000000) 2019/02/10-18:32:20.824 TRACE_LEVEL_INFORMATION HID Interrupt Channel connection established 2019/02/10-18:32:20.824 TRACE_LEVEL_VERBOSE L2CAP_PS3_ConnectionStateConnected Entry 2019/02/10-18:32:20.824 TRACE_LEVEL_VERBOSE L2CAP_PS3_ConnectionStateConnected Exit 2019/02/10-18:32:20.824 TRACE_LEVEL_VERBOSE L2CAP_PS3_InterruptConnectResponseCompleted Exit 2019/02/10-18:32:20.824 TRACE_LEVEL_VERBOSE BthPS3_EvtWdfChildListCreateDevice Entry 2019/02/10-18:32:20.824 TRACE_LEVEL_VERBOSE BthPS3_EvtWdfChildListCreateDevice Exit
And there we have the HID Input Report in the function driver
2019/02/10-18:34:23.749 TRACE_LEVEL_INFORMATION InputReport_EvtTimerFunc Entry 2019/02/10-18:34:23.757 TRACE_LEVEL_INFORMATION A1 01 00 00 00 00 00 80 80 7D 85 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 03 03 14 FF C2 00 00 23 D6 77 00 40 02 00 02 04 01 A3 01 FF 2019/02/10-18:34:23.757 TRACE_LEVEL_INFORMATION InputReport_EvtTimerFunc Exit
Alright, time to properly polish and fix power management.
I've implemented dropping all connections in case of
bthenum surprise removal (unplugging the USB Bluetooth dongle without warning), freeing memory and instructing child device (PDO) removal. This works well and allows unloading the driver, so no dangling objects here. But as soon as the function driver attaches, everything stalls on surprise removal. I haven't yet had the time to debug/implement it but I can document a few assumptions to help me later when I pick it up again.
EvtWdfIoQueueIoInternalDeviceControlsends BRBs synchronously out of convenience, this probably isn't the brightest idea, will adjust that to asynchronous
- PDO might be missing PNP/Power capabilities
- Queue I/O stop callback isn't invoked
- Maybe implement self-managed I/O flush callback?
I bet it's an easy fix and I'm just overthinking the issue. Will pick up development again in a few days
Surprise removal power-down sequence fixed!
Two things had to be done (properly):
- In EVT_WDF_IO_QUEUE_IO_INTERNAL_DEVICE_CONTROL I've converted every BRB submission to asynchronous I/O which avoids clogging up the queue dispatch callback and also slightly improved performance and resource usage (memory for request and payload buffer)
- EVT_WDF_IO_QUEUE_IO_STOP calls WdfRequestCancelSentRequest to complete pending requests sent to the I/O target (in this case our Bluetooth parent FDO)
Another step closer to finishing and hardening the profile/bus driver
Aha! It only happens when I send data to the HID Control Channel, how interesting We'll see about that... :male-detective:
Ha, found it! Now that's more like it:
Purple is non-paged memory from HCI-specific pool now only slightly jittering up and down as expected. Green is the BTHP pool which is now steady as well. The uneven bumps are probably owed to timing in the driver and probably latency on the radio link.
So what was the issue? Well, previously I was only writing to the HID Control Channel (periodically) because that's how the HID Output Report travels to the remote device. Now since I couldn't find any issues with my memory handling in my own drivers I was starting to experiment and implemented reading from the control channel (where there shouldn't be any data coming back because the DS3 sends data over the HID Interrupt Channel) as well and look at that: with every packet I send out there's one byte of "response" available to read as well! The content is always a solid
0x00 but still, this was allocating and holding memory in the lower sections of
bthport.sys and the reason for the rise in non-paged memory usage. I'm now also periodically reading and therefore "emptying" the control channel and now it's not growing anymore. Nice!
Time for a break
Guess some sort of Writer's Block got me, but for coding. No worries though, will do something else then until the spirits are up for it again
Can't wait to connect my Ps3 controller via bluetooth to pc without installing malicious software (it's this project all about this right?, if yes, when it will be released? )
@epikvigem pretty much sums it up, yeah This set of drivers will allow you to use the popular PS3 peripherals (DualShock 3, Navigation & Move Controllers) transparently with little overhead on Windows 7 up to 10.
As for the estimated release schedule... If the current pace stays where it is I aim for early or mid May?
@nefarius this looks awesome! Really looking forward to seeing this in production! Is there anything we as a community can do or provide to assist your work? Beta testing, experiment with various BT dongles/pads, or just show interest in your product? What kind of licensing are you thinking about once this is ready? Propriety paid/free, open source and all its variations, dual - community version open source (without binaries) VS paid WHQL certified?
!ERAU QSSI DLRO WEHT
@Locksmith pardon the delay, I wanted to answer this in detail as it contains a lot of interesting and valid questions.
I will be getting to a stage where the full stack can be tested and I would greatly appreciate it if I get a few owners of those obviously "fake" and aftermarket DualShock "PANHAI" controllers since I can't order them in my country and back in SCP-days a rather large demographic was interested in getting them to work as they typically only cost around 10$. I'm not a fan of those personally but if they work on the stack with ease, be my guest As I own the genuine Sony hardware I can guarantee a 100% compatibility for those obviously. Just a heads-up: I won't give out production-signed binaries to beta testers anymore though as that's irresponsible. So anybody interested would be required to put his or her machine into test mode. Usually not a big deal but I've heard that a few anti-cheat and DRM solutions out there won't let you launch certain games anymore until reverted.
Dongle compatibility shouldn't be much of an issue anymore as the vendor software stack is kept in place and isn't touched anymore (unlike SCP) so e.g. Intel Wireless cards will keep operating with the Intel vendor driver. Tests welcome though nonetheless.
Last but not least I ofc. welcome interest in my post-
apocalypticSCP shenanigans I've launched into this mess out of personal motivation; getting comfortable with yet another kernel-mode driver, the Windows Bluetooth Driver Interface, WHQL-fun and maybe finally getting a finished plug-and-play solution so I can visit my couch again and play Castlevania A lot of what's happening here currently is straight out research and development. As a lot of people are apparently not understanding (or accepting) what "work in progress" means I keep "advertising" for the forum etc. to a minimum as long as there's not enough resources for me to research, develop, give support, regularly update news etc. This doesn't mean I want to stay in my own bubble here, I welcome anybody interested but in return I expect acceptance if things don't quite go according to plan.
Despite a few "hiccups" I've had with larger corporations
taking my stuff being a bit clumsy in the past I'm still a big advocate and believer in open-source. First and foremost because I'd probably not be in this "business" of dealing with gaming peripherals if the mad lad creating SCP hadn't open-sourced his or her work plus all of the other fabulous projects and samples I profited of by studying the sources. This also includes non-Windows sources like bits and pieces in the Linux kernel or Arduino projects. So I'll definitely open-source this stack as well once I tag it production-ready.
Now one might ask why this time I didn't go for GitHub from the very beginning but use a private Git repository instead. It makes developing the back-doors so much easier! Jokes aside, once again this is another measure I had to take to protect myself from idiocy. What I've noticed over the years is that non-developers who find something interesting on GitHub usually ignore the README and other helpful resources completely, get confused because there is no "download EXE here now" button and then come haunt and annoy me and my team with questions that could've been avoided from the very start. I have no problem with answering questions but if I get used as a search engine replacement I take that as a personal offense as you clearly show me that you don't value my time. Phew, that went sour fast
Back to licensing. With upcoming releases I'm gonna include an EULA to both protect myself (you know, warranty, haha) and probably place some restrictions on it regarding commercial use. Maybe dual-licensing it. Again, there are reasonable motivations behind it. To private individuals I wanna ensure all the freedom and openness as possible as that's the target demographic. Corporations though are dumb. What do I mean by that? Well, just forking a driver, re-branding and releasing it (not that this has happened before, huehuehue) is a horrible practice. Drivers need maintenance and the knowledge on how to maintain them properly. If they cause an issue on an end-users machine it needs to be diagnosed and addressed. Can they provide that? No, they'll conveniently send them to me who's expected to give free support and fix everything. Nope, get fucked, GPL and other restrictions it will be for you then. I haven't settled on the best solution there yet but I'm working on ideas that benefit all sides as much as possible.
Regarding WHQL... Binaries without it aren't really worth it nowadays so it's either just the sources and have fun or a properly signed binary. Could I sell it? Eh. Would it sell? Eh. Would I take a few Schekels if offered? Oh, absolutely, the bills haven't stopped I need to figure this out. Bring back donations? Eh. Maybe they'll flourish again if a finished attractive product is released? So many questions, so little time. We'll figure it out
I think I've got everything out I wanted to address, pardon the wall of text